Skip to content

[xharness] Use XmlReaderSettings to ignore stuff we don't care about when parsing xml. #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
Sep 25, 2020
Merged

[xharness] Use XmlReaderSettings to ignore stuff we don't care about when parsing xml. #9703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/XmlResultParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@ public bool IsValidXml (string path, out XmlResultJargon type)
bool failedTestRun = false; // result = "Failed"
testcasecount = passed = failed = inconclusive = skipped = 0L;

using (var reader = XmlReader.Create (stream)) {
var settings = new XmlReaderSettings ();
settings.IgnoreWhitespace = true;
settings.IgnoreComments = true;
settings.IgnoreProcessingInstructions = true;

using (var reader = XmlReader.Create (stream, settings)) {
while (reader.Read ()) {
if (reader.NodeType == XmlNodeType.Element && reader.Name == "test-run") {
long.TryParse (reader ["testcasecount"], out testcasecount);
Expand Down