[UIKit] Enable nullability and clean up UITableViewCell.#24694
[UIKit] Enable nullability and clean up UITableViewCell.#24694rolfbjarne merged 1 commit intomainfrom
Conversation
This is file 24 of 30 files with nullability disabled in UIKit.
* Enable nullability (#nullable enable).
* Remove unused using directives (CoreFoundation, UIKit, CoreGraphics).
* Make reuseIdentifier parameter nullable (string?) since null is valid to indicate non-reusable cells.
* Cast null to NSString? instead of NSString for nullable correctness.
* Replace include XML doc attribute with inline content from docs/api/UIKit/UITableViewCell.xml and remove the inlined entry from the XML file.
* Fix typo ('mutiple' → 'multiple') in the inlined documentation.
Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types for the UIKit UITableViewCell convenience constructor file and migrates the constructor’s XML documentation from the external docs XML into inline C# XML doc comments, aligning the API’s nullability with UIKit semantics.
Changes:
- Enabled
#nullableinsrc/UIKit/UITableViewCell.csand removed now-unneededusingdirectives. - Updated
UITableViewCell (UITableViewCellStyle, string)to acceptstring? reuseIdentifierand adjusted theNSStringconversion to be nullable-correct. - Inlined the constructor documentation into the C# file, removed the corresponding
Docsentry fromdocs/api/UIKit/UITableViewCell.xml, and fixed the “mutiple” → “multiple” typo during the move.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/UIKit/UITableViewCell.cs | Enables nullability, updates ctor parameter to string?, and inlines the ctor’s XML documentation. |
| docs/api/UIKit/UITableViewCell.xml | Removes the ctor documentation entry that was previously included into the C# source. |
✅ [PR Build #e98c3ba] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #e98c3ba] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #e98c3ba] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #e98c3ba] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #e98c3ba] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #e98c3ba] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #e98c3ba] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #e98c3ba] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #e98c3ba] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 126 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 24 of 30 files with nullability disabled in UIKit.
Contributes towards #17285.