Skip to content

[JavaTypeSystem] Add JavaFieldModel.ToString ().#1144

Merged
jonpryor merged 1 commit intomainfrom
field-tostring
Sep 14, 2023
Merged

[JavaTypeSystem] Add JavaFieldModel.ToString ().#1144
jonpryor merged 1 commit intomainfrom
field-tostring

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Sep 14, 2023

Context: https://discord.com/channels/732297728826277939/732297837953679412/1151531791069499524

A user reported the following output in their java-resolution-report.log:

The field 'Java.Interop.Tools.JavaTypeSystem.Models.JavaFieldModel' was removed because its name contains a dollar sign.
The class '[Class] com.google.android.libraries.navigation.internal.aac.ad' was removed because the Java base type 'com.google.android.libraries.navigation.internal.aad.ar<com.google.android.libraries.navigation.internal.aac.af<K, V>>' could not be found.

We should be providing the user with the name of the removed field rather than the JavaFieldModel type name. To do this, add an appropriate JavaFieldModel.ToString ().

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants