Update License

[krwq]

Update License to match dotnet/arcade@1e49672
and fix issue with #339

@chcosta I'm not 100% sure if this is fixing the issue with that PR but seems that's what the error is about, please let me know if that's not it (that's the only difference I could think of)

[chcosta]

That looks like a partial fix. When you update the sdk in your repo's global.json (to 2.1.503 or newer), you'll need to apply this change as well. I'd suggest you just do that now unless there's some strong reason you can't upgrade your repo's SDK version.

FYI @tmat

[tmat]

Remove
https://github.com/dotnet/iot/blob/master/Directory.Build.props#L25
https://github.com/dotnet/iot/blob/master/Directory.Build.props#L19
since we are using license expression rather than embedding license file.

You can also remove the condition on line https://github.com/dotnet/iot/blob/master/Directory.Build.props#L6.

[joperezr]

Once you make the fixes that @chcosta and @tmat suggested this LGTM. Thanks for fixing! it will be great to start getting arcade updates again!

[krwq]

not sure if I understood correctly what needs to be changed - I'm not too familiar with Arcade (presumably since we have default copyright now I don't need to define it anymore)?

[krwq]

I'm getting errors about:

C:\Program Files\dotnet\sdk\2.1.503\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(202,5): error NU5035: The PackageLicenseUrl is being deprecated and cannot be used in conjunction with the PackageLicenseFile or PackageLicenseExpression. [F:\vsagent\134\s\src\Iot.Device.Bindings\Iot.Device.Bindings.csproj]
C:\Program Files\dotnet\sdk\2.1.503\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(202,5): error NU5035: The PackageLicenseUrl is being deprecated and cannot be used in conjunction with the PackageLicenseFile or PackageLicenseExpression. [F:\vsagent\134\s\src\System.Device.Gpio\System.Device.Gpio.csproj]

I suspect I just need to update tools to higher version, do you perhaps have the right number? (I didn't get any result when grepped for PackageLicenseUrl or PackageLicenseFile)

[tmat]

2.1.503 should be good enough.

Your build doesn't collect log artifacts, so we can't look at a build log :(

BTW, delete https://github.com/dotnet/iot/blob/master/src/Iot.Device.Bindings/Directory.Build.props#L7 and https://github.com/dotnet/iot/blob/master/src/System.Device.Gpio/Directory.Build.props#L8

[joperezr]

I've merged my changes to publish the build logs, so I'm restarting the builds so that we can better analyze why is the build failing

[joperezr]

restarting didn't take my changes, I'll try closing and reopening the PR. If that doesn't work, We may need that @krwq rebase to get my yml changes.

[joperezr]

Ok, so according to the logs, the thing you need to remove is line

iot/Directory.Build.props

Line 8 in c6a421b

<PackageLicenseExpression>MIT</PackageLicenseExpression>

Simply remove the line that sets the expression property, and build should pass now.

[tmat]

That is not the right fix. Please keep the license expression.

[joperezr]

@tmat I just reverted the change. Do you know what is the right fix then? You should be able to take a peek at the logs now, the one you care about is Windows_NT_release_configuration/Build.binlog

[joperezr]

Looks like all we needed after your suggestions was actually to perform an update of arcade. @tmat is this good to go now?

[tmat]

actually to perform an update of arcade.

Ah, that explains. I assumed the update already happened.