[release/8.0.1xx-preview3] Update dependencies from dotnet/sdk#15905
Merged
dotnet-maestro[bot] merged 3 commits intoMar 24, 2023
Conversation
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.3.23170.5 -> To Version 8.0.100-preview.3.23172.4 Dependency coherency updates Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset,NuGet.Build.Tasks From Version 8.0.0-preview.3.23169.3 -> To Version 8.0.0-preview.3.23170.14 (parent: Microsoft.NET.Sdk
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dotnet/source-build-internal Could you take a look at the failures here? |
| @@ -23,7 +23,7 @@ | ||
| <TargetFrameworksExeForSigning Condition=" '$(IsXPlat)' == 'true' ">$(NETCoreTargetFramework);netcoreapp5.0</TargetFrameworksExeForSigning> | ||
| <TargetFrameworksExeForSigning Condition="'$(DotNetBuildFromSource)' == 'true'">$(TargetFrameworksExe);net7.0</TargetFrameworksExeForSigning> | ||
| @@ -26,7 +26,7 @@ |
Member
There was a problem hiding this comment.
@crummel where is this coming from? If we are disabling TFM trimming, only the second set of changes is needed, i.e. a single TargetFrameworksLibrary change. My original change is: NuGet/NuGet.Client@2da00ae
Member
There was a problem hiding this comment.
OK - this looks good.
There was a problem hiding this comment.
There's no real change to your patch, just the context lines changed which caused it to fail.
NikolaMilosavljevic
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/sdk