Fix #492 - use ConvILTypeRefUnadjusted not ConvILTypeRef#510
Closed
latkin wants to merge 1 commit intodotnet:fsharp4from
Closed
Fix #492 - use ConvILTypeRefUnadjusted not ConvILTypeRef#510latkin wants to merge 1 commit intodotnet:fsharp4from
latkin wants to merge 1 commit intodotnet:fsharp4from
Conversation
Contributor
Author
There was a problem hiding this comment.
@dsyme there is now only one direct use of ConvILTypeRef, below on line 978. Can you take a second look and confirm that this call is correct?
Contributor
There was a problem hiding this comment.
There would certainly be no harm in adjusting that one for uniformity, but its harmless either way - the case is only used for the built-in primitive types like these: https://github.com/Microsoft/visualfsharp/blob/fsharp4/src/fsharp/FSharp.Core/prim-types-prelude.fsi#L73 as mentioned here https://github.com/Microsoft/visualfsharp/blob/275b832e9dd1a4bd64ed3accd218384b901be1d2/src/fsharp/tast.fs#L3681. I think this specific case is probably only used for nativeptr if at all.
Contributor
Author
|
This guy has also been approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use correct API when encoding quoted assembly references.
ConvILTypeRefUnadjustedproperly handles the case where the reference is statically linked.ConvILTypeRefdoes not.These two used to be a single API. They were split in
640db00and it was a simple oversight that the wrong one was wired up here.We have private tests which cover these type providers, they were simply never run in a cross-version configuration. That's frustrating, as cross-version testing was automated recently with Automated cross-targeting testing #446. Running those tests, the bug would have been found a month ago. With the fix, they all pass.