Merged
Conversation
Contributor
|
auduchinok
reviewed
Jun 6, 2025
Member
auduchinok
left a comment
There was a problem hiding this comment.
@edgarfgp Thanks a lot! I've added a few ideas about trying to make it a bit simpler
tests/FSharp.Compiler.ComponentTests/ErrorMessages/AbbreviationTests.fs
Outdated
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/ErrorMessages/AbbreviationTests.fs
Outdated
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/ErrorMessages/AbbreviationTests.fs
Outdated
Show resolved
Hide resolved
T-Gro
approved these changes
Jun 9, 2025
Member
T-Gro
left a comment
There was a problem hiding this comment.
Thanks for the addition.
I agree with @auduchinok on the naming - we can exclude name of the surrounding module/namespace, and make test names shorted.
(and I know that this isn't always met in existing tests, including the ones I have authored)
Contributor
Author
|
This is ready. I wanted to raise couple PR's regarding error recovery for CheckExpressions.fs |
Contributor
Author
|
@T-Gro Can we merge this ? |
T-Gro
added a commit
that referenced
this pull request
Jun 24, 2025
* More test for error recovery (#18669) * [main] Update dependencies from dnceng/internal/dotnet-optimization (#18683) * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250610.1 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25310.1 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250611.1 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25311.1 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250616.1 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25316.1 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250617.1 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25317.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Tomas Grosup <[email protected]> * [main] Update dependencies from dotnet/arcade (#18643) * Expand docstring on SynModuleDecl.Types (#18698) * Update dependencies from https://github.com/dotnet/arcade build 20250620.5 (#18703) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.25316.2 -> To Version 10.0.0-beta.25320.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Remove feature/lsp merge from branch-merge.yml (#18705) Cleaning up, sicne we've merged feature/lsp to main some time ago * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250623.1 (#18710) optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.25317.1 -> To Version 1.0.0-prerelease.25323.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20250623.3 (#18709) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.25320.5 -> To Version 10.0.0-beta.25323.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Remove ActivityDisposable conditional directives and replace with System.IDisposable | null (#18707) --------- Co-authored-by: Edgar Gonzalez <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: Patrick Stevens <[email protected]> Co-authored-by: Adam Boniecki <[email protected]> Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add extra test to showcase how the error recovery was improved in #18645
Thanks to @auduchinok for requesting this and to Claude for helping with the test names. :)
Checklist