Add support for C# Experimental attribute#18253
Merged
T-Gro merged 14 commits intodotnet:mainfrom Feb 10, 2025
edgarfgp:fix-18198
Merged
Add support for C# Experimental attribute#18253T-Gro merged 14 commits intodotnet:mainfrom edgarfgp:fix-18198
Experimental attribute#18253T-Gro merged 14 commits intodotnet:mainfrom
edgarfgp:fix-18198
Conversation
Contributor
❗ Release notes required
|
Experimental attributeExperimental attribute
T-Gro
reviewed
Jan 23, 2025
T-Gro
reviewed
Jan 23, 2025
T-Gro
reviewed
Jan 23, 2025
Contributor
|
Is there some reason this is insufficient? https://github.com/dotnet/fsharp/blob/main/src/FSharp.Core/prim-types.fs#L265 |
Member
@edgarfgp added support for detecting the same attribute which was added in .NET / supported by C#12+ - https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-12.0/experimental-attribute |
psfinaki
reviewed
Feb 6, 2025
psfinaki
reviewed
Feb 6, 2025
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
T-Gro
approved these changes
Feb 10, 2025
psfinaki
approved these changes
Feb 10, 2025
Contributor
psfinaki
left a comment
There was a problem hiding this comment.
Good stuff, thanks Edgar!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18198
Checklist