Fix internal error when missing measure attribute in an unsolved measure typar#18234
Merged
T-Gro merged 7 commits intodotnet:mainfrom Jan 20, 2025
edgarfgp:fix-7491
Merged
Fix internal error when missing measure attribute in an unsolved measure typar#18234T-Gro merged 7 commits intodotnet:mainfrom edgarfgp:fix-7491
T-Gro merged 7 commits intodotnet:mainfrom
edgarfgp:fix-7491
Conversation
Contributor
❗ Release notes required
|
edgarfgp
commented
Jan 14, 2025
Contributor
|
@edgarfgp a question, partially orthogonal and out of curiosity. While doing the investigation, have you got an understanding on why is the attribute duplication actually needed there? AFAIU (might be wrong, you are the attribute guru here) - inheritance should work normally for attributes, so attribute properties should apply to the derived entities. I'm getting a suspicion that something is broken more deeply here. I've noticed different behavior between C# and F# here: |
Contributor
Author
Contributor
|
Right - told ya, you're the attribute guru. At least that's a known issue then... |
psfinaki
approved these changes
Jan 20, 2025
T-Gro
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes #7491
BEFORE
AFTER
(Error 3874, Line 9, Col 12, Line 9, Col 14, "Expected unit-of-measure type parameter must be marked with the [<Measure>] attribute.")Checklist