Improve error reporting for abstract members when used in classes#17063
Merged
psfinaki merged 14 commits intodotnet:mainfrom Apr 19, 2024
edgarfgp:abstract-member-on-classes-reporting
Merged
Improve error reporting for abstract members when used in classes#17063psfinaki merged 14 commits intodotnet:mainfrom edgarfgp:abstract-member-on-classes-reporting
psfinaki merged 14 commits intodotnet:mainfrom
edgarfgp:abstract-member-on-classes-reporting
Conversation
Contributor
❗ Release notes required
|
edgarfgp
commented
Apr 18, 2024
...FSharp.Compiler.ComponentTests/Conformance/GeneratedEqualityHashingComparison/Basic/Basic.fs
Show resolved
Hide resolved
edgarfgp
commented
Apr 19, 2024
T-Gro
reviewed
Apr 19, 2024
T-Gro
approved these changes
Apr 19, 2024
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
psfinaki
reviewed
Apr 19, 2024
psfinaki
approved these changes
Apr 19, 2024
Contributor
psfinaki
left a comment
There was a problem hiding this comment.
Sorry for nitpicking. Good job :)
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up: #17055
Checklist