More ValueOption in compiler: part 3 (and the last)#16822
Merged
psfinaki merged 13 commits intodotnet:mainfrom May 13, 2024
Merged
More ValueOption in compiler: part 3 (and the last)#16822psfinaki merged 13 commits intodotnet:mainfrom
psfinaki merged 13 commits intodotnet:mainfrom
Conversation
Contributor
❗ Release notes required
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vzarytovskii
requested changes
Mar 8, 2024
tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.SurfaceArea.netstandard20.debug.bsl
Show resolved
Hide resolved
This reverts commit 948b8c3.
T-Gro
reviewed
Mar 11, 2024
tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/ValueOptionBenchmarks.fs
Outdated
Show resolved
Hide resolved
vzarytovskii
requested changes
Mar 18, 2024
Member
vzarytovskii
left a comment
There was a problem hiding this comment.
We'll have to wait with this one for now, since now we're having some live issues with SO
3 tasks
Member
|
I've merged couple of fixes and workarounds for the SOs in CEs and in big nested expressions. We can probably merge this one (extra would be to test AnyCpu variant on those). |
Contributor
|
These performance improvements are quite impressive and more than I'd expect from such change. Nice! |
T-Gro
approved these changes
May 7, 2024
Contributor
Author
abonie
approved these changes
May 13, 2024
vzarytovskii
approved these changes
May 13, 2024
This was referenced May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16286
If my RegEx is correct, this should be it.
Some benchmarks (for what was easy to bench):
Before:
After: