Smoke test some benchmarks in CI#16554
Merged
psfinaki merged 4 commits intodotnet:mainfrom Jan 24, 2024
Merged
Conversation
Contributor
✅ No release notes required |
vzarytovskii
previously requested changes
Jan 19, 2024
Contributor
Author
Discussed offline - this just checks that the benchmark tests themselves are sane. We can give this a try:
|
abonie
approved these changes
Jan 24, 2024
KevinRansom
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revives and builds on the smoke tests for benchmarks introduced by @safesparrow here. It doesn't check anything new in FCS, it just verifies that the benchmarks themselves don't explode.
A few notes:
dotnet build FSharp.Benchmarks.slnto see that everything compiles and then dobuild.cmdso that we can execute FCS bench smoke tests. This is not a big waste of timeshortandlongcategories and run only short ones (that's the majority though)longcategory and run everything else, but this doesn't seem to be possible yet (and filtering by name would be too much hardcoding)fsharpcategory is removed since it wasn't universal and wasn't usedjob Drysupersedes hand-specifying all the job parameters)Running this immediately detected a broken benchmark (assuming Giraffe presence on the machine) so it's disabled.
The smoke testing now takes about 18 minutes, the whole job around 35 minutes. So it's not the longest - and we don't want it to be, hence if needed we can mark more benchmarks as "slow" and not smoke test them.
closes #16407
closes #16408