Fix #16398 - The dotnet framework has a limit of ~64K methods in a single class.#16427
Merged
KevinRansom merged 1 commit intodotnet:mainfrom Dec 14, 2023
Merged
Fix #16398 - The dotnet framework has a limit of ~64K methods in a single class.#16427KevinRansom merged 1 commit intodotnet:mainfrom
KevinRansom merged 1 commit intodotnet:mainfrom
Conversation
c38a178 to
887298e
Compare
T-Gro
approved these changes
Dec 13, 2023
vzarytovskii
approved these changes
Dec 14, 2023
1d27587 to
9d9993b
Compare
Contributor
|
That "64k methods ought to be good enough for anyone" fable must be true. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit a type to 65K methods.
Ensure that while writing the assembly, ensure that no type has more than approx 64K. Includes property setters/getters/constructors and event methods.
Technically this is a breaking change, however, a type with more than 64K methods, will not be loadable at runtime by the CLR, so warning on compilation is a vast improvement.
I have added a couple of test cases but we may want to disable them as they add about 8 minutes to the test execution time.
Fixes #16398