You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expect it to fail at first, since we have some badly formatted tests in the Salsa suite and preview has the parser recovery changes, which promote it to error by default (with a way to opt-out).
Update: Tests are properly formatted in the last commit, so the CI won't fail on them with latest lang version (please note, that the failure is intentional, based on @auduchinok's parser recovery changes). Update 2:FSharpLangVersion is used instead of LangVersion because it was failing for our only vbproj
I'm a bit late to the party, but maybe we could have a separate CI leg with --strict-indentation+ from #15491 in addition to this one? There're many other features in the preview, and probably it would be great to see this change enabled separately from them too.
There's a failure in the preview leg, and the tree produced in TypedTreeOps looks correct to me:
Having a separate leg would make it much easier to spot the parsing regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect it to fail at first, since we have some badly formatted tests in the Salsa suite and preview has the parser recovery changes, which promote it to error by default (with a way to opt-out).
Update: Tests are properly formatted in the last commit, so the CI won't fail on them with latest lang version (please note, that the failure is intentional, based on @auduchinok's parser recovery changes).
Update 2:
FSharpLangVersionis used instead ofLangVersionbecause it was failing for our only vbproj