Parser: recover on unfinished constructors

[auduchinok]

Add recovery for various constructors:

type T()

type T() as = class end

type T() as this

type T() as

type T as this

type T as

type T() =
    new ()

type T() =
    new () =

type T() =
    new () as = ()

type T() =
    new () as

type T() =
    new () as this

[auduchinok]

This is ready. 🙂

[auduchinok]

Rebased on top of the main, so the parser tests include the type checker run.

[psfinaki]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[auduchinok]

Alright, I've cherry picked the lost baseline update, and now it's green again 🙂

[edgarfgp]

@auduchinok Would it make sense also to cover the case where unfinished code with a private constructor?

type A =
    private  { // Error recovery if { is missing
        _B: int
    } // Error recovery if } is missing
    static member Create(b) =
        { _B = b }
    member this.B = this._B

[auduchinok]

@edgarfgp There're no constructors in your code snippet.

Speaking about a missing { in a record representation, I don't think it's the order in which people normally type these things, and I wouldn't call it unfinished code in the same sense as in this PR, where the aim is to mostly help parser during typing. My guess is people usually type the braces before the typing in the fields, not the other way around.

[edgarfgp]

@edgarfgp There're no constructors in your code snippet.

Speaking about a missing { in a record representation, I don't think it's the order in which people normally type these things, and I wouldn't call it unfinished code in the same sense as in this PR, where the aim is to mostly help parser during typing. My guess is people usually type the braces before the typing in the fields, not the other way around.

Thanks for the explanation :)