Remove type provider warning dialog

[enricosada]

When i add a type provider assembly i get this scary warning

That's ok, is a security issue.
The warning is by assembly location, i get this every project X type provider

But there are other components inside visual studio with the same issue.

When i add a Text Template (t4) i get this warning dialog.
There is a checkbox do not show this message again ( i found the image on google, i suppressed the warning long time ago ). Only one time, per user

No warning with:

• nuget, who can execute custom powershell script on install
• roslyn analizer
• test runner from nuget packages (like xunit.runner.visualstudio )
• package manager inside visual studio like npm, python etc

I'd like to remove the warning dialog, but maybe we can just disable it:

• ok: add checkbox like t4
• best: disable this dialog by default, enable it with in visual studio f# config
• complicated: rules by assemblyname/publisher/nuget

i can implement the code.

I really hate this dialog 😄 because when i explain the f# strenghts the type providers seem dangerous

[ovatsus]

This dialog box also really annoys me. Some times you clone a project and build, and then there is a nuget restore and everything fails because this dialog will only show up after the build ends, because when you opened the project the TP reference wasn't there yet

Having a don't ask again checkbox would be great

[forki]

I'm not sure who makes such decisions at Microsoft, but I assume if we want to change that then the T4 way is our best bet.
That said: the security concerns are valid, but then every nuget package had to come with such a disclaimer. Especially since NuGet is running ps1 files during install.

[philderbeast]

That I can build solutions on the command line without a type provider warning or error but from the IDE I get a warning dialog and a build failure is not consistent.

[forki]

Sssh please don't tell anyone about this. They might change this and break our CI builds ;-)

[vasily-kirichenko]

👍 for the checkbox. The dialog is very annoying.

[dsyme]

Yes, I feel a checkbox seems like a reasonable way to make progress.

[enricosada]

remove it is the title 🔥 🔥 , but i can settle for checkbox 😄

[allykzam]

Jumping in from F# weekly, the most annoying part of this dialog for me is that if I use the same type provider in two different projects, I get the dialog once for each project because the binary has a different file path. I assume the OSS type providers aren't distributed as signed binaries, so perhaps Visual Studio could track type providers by their assembly name and checksums of the binary files that come with it?

I'd love to be able to just turn off the dialog box as suggested, but if a safer solution is needed, that's my 2¢

[rojepp]

@amazingant Then you'd have this dialog for each nuget/paket update instead.

Authorisation per Nuget package id would be ideal (If I trust V1 I'm likely to trust V2), but you don't always have one.

The suggested checkbox solution seems fine. I'm going to run the code anyway. If it is a TP I'll run the code directly in the IDE. If it is not, I am still going to run the code at run-time. And, as @enricosada said, in the case of a PS script, I'm running arbitrary code on my machine anyway just by installing the package. There is some inherent trust when installing a package.

[allykzam]

@rojepp You say that, but I've yet to update a type provider. I've installed the same ones via NuGet to a dozen different projects and encountered this dialog over and over again due to it validating against the path. Although again, if I can just turn it off altogether as previously suggested, I'm happy with that too. :)

[rojepp]

I update all the time, especially when contributing fixes. :)
We all realize we're not getting rid of it, so checkbox seems a fine solution!

[KevinRansom]

We would certainly consider incorporating a check box to suppress further display of this dialog on a per user basis. I would regard the risk of regressions as low, and so I believe we would take the fix for VS 2015 if a PR arrives over the next week or two. The later it arrives, the more likely it gets pushed to V.Next. At this point the PR should contain the minimum necessary change to add the check box. Please note that getting the necessary internal approval for the change this late means that it is not guaranteed to make it into VS 2015 but we can try. The label will need localization, that's is our responsibility not yours, but it greatly impacts our ability to take the fix.

[enricosada]

Great @KevinRansom , let's try for vs2015.
I know this is an exception because is not a bug but an improvement, really thx for the effort.

As i said i can do it for sure next week (monday or tuesday), but if someone want to step in as first commit that's a great up-for-grab.