Skip to content

Fix contains test #35166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 2 commits into from
Nov 21, 2024
Merged

Fix contains test #35166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3283989
Fix contains test
am11 Nov 20, 2024
3b636af
Force non-nullable to nullable using cast
am11 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/EFCore.Specification.Tests/Query/PrimitiveCollectionsQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,14 @@ await AssertQuery(
[MemberData(nameof(IsAsyncData))]
public virtual async Task Parameter_collection_of_strings_Contains_nullable_string(bool async)
{
var strings = new[] { "10", "999" };
string?[] strings = ["10", "999"];

await AssertQuery(
async,
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => strings.Any(s => s == c.NullableString)));
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => strings.Contains(c.NullableString)));
await AssertQuery(
async,
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => !strings.Any(s => s == c.NullableString)));
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => !strings.Contains(c.NullableString)));
}

[ConditionalTheory]
Expand Down Expand Up @@ -574,7 +574,7 @@ public virtual Task Column_collection_of_nullable_ints_Contains_null(bool async)
public virtual Task Column_collection_of_strings_contains_null(bool async)
=> AssertQuery(
async,
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => c.Strings.Any(s => s == null)),
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => ((string?[])c.Strings).Contains(null)),
assertEmpty: true);

[ConditionalTheory]
Expand Down