[release/8.0] Find the discriminator property even if it is not string#34388
Merged
AndriySvyryd merged 1 commit intorelease/8.0from Aug 10, 2024
Merged
[release/8.0] Find the discriminator property even if it is not string#34388AndriySvyryd merged 1 commit intorelease/8.0from
AndriySvyryd merged 1 commit intorelease/8.0from
Conversation
roji
approved these changes
Aug 10, 2024
This was referenced Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34201
Description
When the discriminator property has the default name, but a non-default type then
HasDiscriminator()returnsnull. This can be considered a regression, because after #33622 the model snapshot always contains this line for affected models, so this issue now impacts many more users.Customer impact
For affected models, all migration operations throw an exception. The workaround is to rename all non-string discriminators, but this is impractical for large models.
How found
Customer reported on 8.0.7
Regression
Yes, from 8.0.6
Testing
Test added.
Risk
Low. Quirk added.