Port System.Runtime.InteropServices.Javascript docs to RC1 by carlossanlop · Pull Request #8390 · dotnet/dotnet-api-docs

carlossanlop · 2022-09-14T21:58:48Z

@gewarren @pavelsavara @lewing @radical

xml/System.Runtime.InteropServices.JavaScript/JSException.xml

xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml

xml/System.Runtime.InteropServices.JavaScript/JSHost.xml

xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml

xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml

xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml

xml/System.Runtime.InteropServices.JavaScript/JSObject.xml

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

jkoritzinsky

LGTM barring any issues from the docs team

xml/System.Runtime.InteropServices.JavaScript/JSObject.xml

xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml

xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml

xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml

...ystem.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml

xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml

xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml

gewarren · 2022-09-15T04:05:50Z

I'm surprised that these APIs were named with the single-L version of "marshaller". I thought we'd settled on double-L.

pavelsavara · 2022-09-15T08:47:35Z

I'm surprised that these APIs were named with the single-L version of "marshaller". I thought we'd settled on double-L.

I followed prior art in System.Runtime.InteropServices APIs

I saw your double-L changes above and I don't have any preference either way.

In any case, thanks for the PR, LGTM.

Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

…e.xml Co-authored-by: Ankit Jain <radical@gmail.com>

opbld34 · 2022-09-15T16:01:11Z

Docs Build status updates of commit 5c7d400:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Runtime.InteropServices.JavaScript/JSException.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSHost.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSObject.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+MemoryView.xml	✅Succeeded	View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

opbld33 · 2022-09-15T16:31:52Z

Docs Build status updates of commit 939a28e:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Runtime.InteropServices.JavaScript/JSException.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSHost.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSObject.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml	✅Succeeded	View
xml/System.Runtime.InteropServices.JavaScript/JSType+MemoryView.xml	✅Succeeded	View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

gewarren · 2022-09-15T16:48:35Z

I'm surprised that these APIs were named with the single-L version of "marshaller". I thought we'd settled on double-L.

I followed prior art in System.Runtime.InteropServices APIs

@pavelsavara "Marshal" with one L is correct. It's "marshalling" and "marshaller" that I'm referring to, and the existing APIs seems to use two L's:

pavelsavara · 2022-09-15T16:57:48Z

@pavelsavara "Marshal" with one L is correct. It's "marshalling" and "marshaller" that I'm referring to, and the existing APIs seems to use two L's:

So the only offender is JSMarshalerArgument ? Luckily that is EditorBrowsableState.Never

gewarren · 2022-09-15T17:36:07Z

@pavelsavara And JSMarshalerType, which has the same attribute.

Question: Do we want to also filter these from docs.microsoft.com?

pavelsavara · 2022-09-15T17:55:22Z

Question: Do we want to also filter these from docs.microsoft.com?

Yes all which is EditorBrowsableState.Never, because most of that API is there for code generated by Roslyn compiler.

Perhaps [LibraryImport] infrastructure also has some new APIs which are for Roslyn only too ? @jkoritzinsky

jkoritzinsky · 2022-09-15T18:09:44Z

We have some APIs aimed at being used from the generator, but we don't have any EditorBrowsableState.Never ones.

System.Runtime.InteropServices.Javascript RC1

b9bda65

carlossanlop requested a review from gewarren September 14, 2022 21:58

carlossanlop self-assigned this Sep 14, 2022

carlossanlop requested review from AaronRobinsonMSFT and jkoritzinsky as code owners September 14, 2022 21:58

ghost added the area-System.Runtime.InteropServices label Sep 14, 2022

This was referenced Sep 14, 2022

Undocumented 7.0 APIs in System.Runtime.InteropServices.Javascript dotnet/runtime#74734

Closed

System.Runtime.InteropServices.Javascript does not generate intellisense? dotnet/runtime#75633

Closed

This comment was marked as outdated.

Sign in to view

carlossanlop mentioned this pull request Sep 14, 2022

CI Update - .NET 7 RC 1 #8380

Merged

jkoritzinsky requested review from lewing and pavelsavara September 14, 2022 22:34

gewarren reviewed Sep 14, 2022

View reviewed changes

First batch of suggestions by gewarren

53a2b70

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

jkoritzinsky approved these changes Sep 14, 2022

View reviewed changes

Next batch of suggestions by gewarren.

be2ed54

carlossanlop requested a review from gewarren September 14, 2022 23:56

This comment was marked as outdated.

Sign in to view

carlossanlop commented Sep 15, 2022

View reviewed changes

xml/System.Runtime.InteropServices.JavaScript/JSObject.xml Outdated Show resolved Hide resolved

Apply suggestions from code review

650a641

This comment was marked as outdated.

Sign in to view

radical reviewed Sep 15, 2022

View reviewed changes

xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml Outdated Show resolved Hide resolved

radical reviewed Sep 15, 2022

View reviewed changes

xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml Outdated Show resolved Hide resolved

It's -> This API is

a5985ec

gewarren approved these changes Sep 15, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

pavelsavara mentioned this pull request Sep 15, 2022

JavaScript interop dotnet/blazor-samples#41

Closed

guardrex mentioned this pull request Sep 15, 2022

New Blazor JS interop dotnet/AspNetCore.Docs#27016

Closed

carlossanlop and others added 2 commits September 15, 2022 08:30

Apply suggestions from code review

5c7d400

Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribut…

939a28e

…e.xml Co-authored-by: Ankit Jain <radical@gmail.com>

carlossanlop merged commit 0effa38 into dotnet:net7-rc1 Sep 15, 2022

carlossanlop deleted the JavascriptRC1 branch September 15, 2022 16:14

carlossanlop mentioned this pull request Sep 15, 2022

Bump Intellisense RC2 package version again dotnet/runtime#75698

Merged

gewarren mentioned this pull request Sep 15, 2022

Filter out JS interop APIs for compiler #8392

Merged

Conversation

carlossanlop commented Sep 14, 2022

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

jkoritzinsky left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gewarren commented Sep 15, 2022

Uh oh!

This comment was marked as outdated.

pavelsavara commented Sep 15, 2022

Uh oh!

opbld34 commented Sep 15, 2022

✅ Validation status: passed

Uh oh!

opbld33 commented Sep 15, 2022

✅ Validation status: passed

Uh oh!

gewarren commented Sep 15, 2022

Uh oh!

pavelsavara commented Sep 15, 2022

Uh oh!

gewarren commented Sep 15, 2022

Uh oh!

pavelsavara commented Sep 15, 2022

Uh oh!

jkoritzinsky commented Sep 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants