Enumerate assignable ThreadPool work queues#5867
Merged
hoyosjs merged 1 commit intoJun 9, 2026
Merged
Conversation
Update ThreadPoolCommand to read current runtime assignable work item queues, include low-priority global work items, and cap assignable queue traversal for corrupt dumps. Runtime history shows _assignableWorkItems never existed; the current SOS-dependent field is _assignableWorkItemQueues, introduced by dotnet/runtime#69386. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ThreadPoolCommand’s managed work-item enumeration to use the ThreadPoolWorkQueue field _assignableWorkItemQueues (since _assignableWorkItems never existed) and expands enumeration to include lowPriorityWorkItems, improving coverage of queued work items across runtime versions.
Changes:
- Add enumeration of
lowPriorityWorkItemsfromThreadPoolWorkQueue. - Replace the nonexistent
_assignableWorkItemspath with enumeration of_assignableWorkItemQueues(array of queues), with a capped traversal limit.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.Diagnostics.ExtensionCommands/ThreadPoolCommand.cs |
Updates work-item enumeration to include low-priority and assignable work-item queues. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
hoyosjs
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ThreadPoolCommand to use _assignableWorkItemQueues, the original _assignableWorkItems actually never existed...