Skip to content

Restore correct Version.Details.xml Source Sha#5818

Merged
hoyosjs merged 1 commit into
mainfrom
adamzip/restore-codeflow-metadata
May 6, 2026
Merged

Restore correct Version.Details.xml Source Sha#5818
hoyosjs merged 1 commit into
mainfrom
adamzip/restore-codeflow-metadata

Conversation

@adamzip

@adamzip adamzip commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

The backflow from the VMR is failing after the Source Sha in eng/Version.Details.xml was changed to an unknown value in #5789. This PR restore it back to the value it had prior to that, which was set by #5589

Copilot AI review requested due to automatic review settings April 29, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the eng/Version.Details.xml <Source> SHA for the dotnet/dotnet dependency mapping back to the previously known value to unblock VMR backflow.

Changes:

  • Update the dotnet/dotnet <Source> Sha to 4e6cfd9762f7562d398be31e2bff79f3e993a9c2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamzip

adamzip commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

@steveisok I see that this repo hasn't received a backflow in a very long time.
The most recent backflow failed because there was some wrong Sha in the Version.Details.xml file, this PR fixes it. If we merge this PR we can retrigger the subscription to get a new backflow PR opened. (CC @max-charlamb @hoyosjs )

@dkurepa

dkurepa commented Apr 29, 2026

Copy link
Copy Markdown
Member

if we do this, we have to FF afterwards, before doing a backflow. Otherwise this commit will be recognized as the last flow, and we might end up losing changes

@adamzip

This comment was marked as outdated.

@dkurepa

This comment was marked as outdated.

@hoyosjs

hoyosjs commented Apr 30, 2026

Copy link
Copy Markdown
Member

Backflows are disabled right now while we do some changes to the infra (arcade 10 based, but need some 11 builds for tests).

@adamzip

adamzip commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

Backflows are disabled right now while we do some changes to the infra (arcade 10 based, but need some 11 builds for tests).

@hoyosjs we can still make this change right now and make the forward flow happen as @dkurepa said. The backflow PR can stay open for as long as you need. But it would be nice to fix this situation now so we don't have to come back to it later

@hoyosjs

hoyosjs commented May 6, 2026

Copy link
Copy Markdown
Member

yeah - I'll let all the FF happen. Just needed to get other breaks in the official build settled before this could flow

@hoyosjs hoyosjs merged commit 96222e8 into main May 6, 2026
23 checks passed
@hoyosjs hoyosjs deleted the adamzip/restore-codeflow-metadata branch May 6, 2026 00:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants