Skip to content

Produce better error messages in gcdump convert command #5814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 3 commits into from
May 30, 2026
+11 −1
Merged

Produce better error messages in gcdump convert command #5814

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1c828e
Produce better error messages in gcdump convert command
pavelsavara Apr 22, 2026
3ff8efa
fix
pavelsavara Apr 22, 2026
a3408e6
Merge branch 'main' into fix/gcdump-convert-rootindex-error-message
pavelsavara May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Tools/dotnet-gcdump/CommandLine/ConvertCommandHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,20 @@ public static int ConvertFile(FileInfo input, string output, bool verbose)

if (!EventPipeDotNetHeapDumper.DumpFromEventPipeFile(input.FullName, memoryGraph, log, heapInfo))
{
Console.Error.WriteLine($"Failed to convert '{input.FullName}' to gcdump. The input file may not be a valid nettrace file, or it may not contain GC heap events. Try running with '-v' for more information.");
Comment thread
pavelsavara marked this conversation as resolved.
return -1;
}

try
{
memoryGraph.AllowReading();
}
catch (ApplicationException ex)
{
Console.Error.WriteLine($"Failed to convert '{input.FullName}': {ex.Message} The nettrace file may not contain a complete GC heap dump. Try running with '-v' for more information.");
Comment thread
pavelsavara marked this conversation as resolved.
return -1;
}

memoryGraph.AllowReading();
GCHeapDump.WriteMemoryGraph(memoryGraph, outputFileInfo.FullName, "dotnet-gcdump");

return 0;
Expand Down
Loading