Sync eng/native from dotnet/runtime#3564
Merged
hoyosjs merged 3 commits intodotnet:mainfrom Dec 21, 2022
Merged
Conversation
mikem8361
approved these changes
Dec 20, 2022
hoyosjs
approved these changes
Dec 21, 2022
Member
|
Thanks @am11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced a breaking change in arcade today: removed bash dependency from
init-compiler.shwhich changed how we call this script. I have pickedeng/nativechanges from dotnet/runtime#77304 and replacing (delete and recursively copy) the entire directory.Ideally we should move all common scripts from
eng/nativeto arcade'seng/common/nativefor changes to automatically flow to all consumers.cc @hoyosjs, @akoeplinger (last sync was #3318)