Update SOS to show thread pool work items from new queues#3080
Merged
Conversation
- Depends on dotnet/runtime#69386 - The PR above added new queues of work items. This change updates the `ThreadPool -wi` command to include showing work items from those new queues. - Verified that the updated SOS works with and without the above PR
mikem8361
approved these changes
May 17, 2022
mikem8361
left a comment
Contributor
There was a problem hiding this comment.
You have a build failure (casting) on Windows x86. Other than that it looks good.
- Renamed a field based on feedback from the dependency PR - Fixed build break on x86 - Previously on x86 it looks like it was reading 8 bytes from an array element of pointer size and only using the lower 4 bytes. Fixed to read only pointer size in a few places. - Verified on x86 and x64
Contributor
|
Is this ready to merge? |
Contributor
Author
|
Not yet, the dependency PR is still open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadPool -wicommand to include showing work items from those new queues.