Merged
Conversation
e391b7d to
066cd2b
Compare
yaakov-h
reviewed
Jul 10, 2020
adamsitnik
reviewed
Jul 10, 2020
adamsitnik
reviewed
Jul 10, 2020
adamsitnik
reviewed
Jul 10, 2020
adamsitnik
reviewed
Jul 10, 2020
akoeplinger
reviewed
Jul 10, 2020
akoeplinger
reviewed
Jul 10, 2020
akoeplinger
reviewed
Jul 10, 2020
akoeplinger
reviewed
Jul 10, 2020
akoeplinger
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
| * **X509Chain** | ||
| - `.ctor(IntPtr)` | ||
|
|
||
| ### System.ServiceModel |
Member
There was a problem hiding this comment.
Someone familiar with WCF will need to comment on this section.
Member
There was a problem hiding this comment.
We have zero api's which are Windows specific.
stephentoub
reviewed
Jul 10, 2020
stephentoub
reviewed
Jul 10, 2020
adamsitnik
reviewed
Jul 14, 2020
adamsitnik
reviewed
Jul 14, 2020
adamsitnik
reviewed
Jul 14, 2020
Contributor
Author
|
FYI. I've done a run for .NET 5 and the latest |
3909780 to
242ba7b
Compare
Contributor
Author
|
@akoeplinger I've rebased out the Excel file 🙂 |
jeffhandley
reviewed
Jul 14, 2020
|
|
||
| ## Open Issues | ||
|
|
||
| * We should run the tool again .NET 5 |
Member
There was a problem hiding this comment.
Suggested change
| * We should run the tool again .NET 5 | |
| * We should run the tool against .NET 5 |
Comment on lines
+281
to
+392
| ### System.ServiceModel | ||
|
|
||
| * **ActionNotSupportedException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| - `.ctor(String, Exception)` | ||
| * **BasicHttpBinding** | ||
| - `.ctor()` | ||
| - `.ctor(BasicHttpSecurityMode)` | ||
| - `CreateBindingElements()` | ||
| * **BasicHttpsBinding** | ||
| - `.ctor()` | ||
| - `.ctor(BasicHttpsSecurityMode)` | ||
| - `CreateBindingElements()` | ||
| * **ChannelFactory** | ||
| - `.ctor(Binding, EndpointAddress)` | ||
| - `.ctor(ServiceEndpoint)` | ||
| - `.ctor(String)` | ||
| - `.ctor(String, EndpointAddress)` | ||
| - `ApplyConfiguration(String)` | ||
| - `CreateDescription()` | ||
| - `InitializeEndpoint(Binding, EndpointAddress)` | ||
| - `InitializeEndpoint(ServiceEndpoint)` | ||
| - `InitializeEndpoint(String, EndpointAddress)` | ||
| * **ChannelTerminatedException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **ClientBase** | ||
| - `.ctor()` | ||
| - `.ctor(String)` | ||
| - `.ctor(String, EndpointAddress)` | ||
| - `.ctor(String, String)` | ||
| * **ClientBase+ChannelBase** | ||
| - `EndInvoke(String, Object[], IAsyncResult)` | ||
| * **ClientCredentialsSecurityTokenManager** | ||
| - `CreateSecurityTokenAuthenticator(SecurityTokenRequirement, SecurityTokenResolver)` | ||
| - `CreateSecurityTokenProvider(SecurityTokenRequirement)` | ||
| - `CreateSecurityTokenSerializer(SecurityTokenVersion)` | ||
| * **CommunicationException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **CommunicationObjectAbortedException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **CommunicationObjectFaultedException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **DuplexChannelFactory** | ||
| - `.ctor(InstanceContext, Binding, EndpointAddress)` | ||
| - `.ctor(InstanceContext, Binding, String)` | ||
| - `.ctor(InstanceContext, String)` | ||
| - `.ctor(InstanceContext, String, EndpointAddress)` | ||
| * **DuplexClientBase** | ||
| - `.ctor(InstanceContext)` | ||
| - `.ctor(InstanceContext, String)` | ||
| - `.ctor(InstanceContext, String, EndpointAddress)` | ||
| - `.ctor(InstanceContext, String, String)` | ||
| * **EndpointAddress** | ||
| - `ApplyTo(Message)` | ||
| * **EndpointIdentity** | ||
| - `Equals(Object)` | ||
| - `GetHashCode()` | ||
| * **EndpointNotFoundException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **FaultException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **InvalidMessageContractException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **MessageHeaderException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **MessageSecurityOverTcp** | ||
| - `get_ClientCredentialType()` | ||
| - `set_ClientCredentialType(MessageCredentialType)` | ||
| * **NetHttpBinding** | ||
| - `CreateBindingElements()` | ||
| * **NetHttpsBinding** | ||
| - `.ctor()` | ||
| - `.ctor(BasicHttpsSecurityMode)` | ||
| - `CreateBindingElements()` | ||
| * **NetTcpBinding** | ||
| - `.ctor(String)` | ||
| - `CreateBindingElements()` | ||
| * **ProtocolException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **QuotaExceededException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **ServerTooBusyException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **ServiceActivationException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
|
|
||
| ### System.ServiceModel.Channels | ||
|
|
||
| * **AddressHeader** | ||
| - `Equals(Object)` | ||
| - `GetHashCode()` | ||
| * **MessageHeaders** | ||
| - `set_To(Uri)` | ||
| * **SecurityBindingElement** | ||
| - `CreateSecureConversationBindingElement(SecurityBindingElement)` | ||
| * **TransportSecurityBindingElement** | ||
| - `GetProperty<T>(BindingContext)` | ||
| * **WebSocketTransportSettings** | ||
| - `get_DisablePayloadMasking()` | ||
| - `set_DisablePayloadMasking(Boolean)` | ||
|
|
||
| ### System.ServiceModel.Security | ||
|
|
||
| * **MessageSecurityException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **SecurityAccessDeniedException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **SecurityNegotiationException** | ||
| - `.ctor(SerializationInfo, StreamingContext)` | ||
| * **X509ServiceCertificateAuthentication** | ||
| - `set_CertificateValidationMode(X509CertificateValidationMode)` | ||
|
|
Member
There was a problem hiding this comment.
Per @mconnew's comment, this suggestion will remove the ServiceModel types.
Suggested change
| ### System.ServiceModel | |
| * **ActionNotSupportedException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| - `.ctor(String, Exception)` | |
| * **BasicHttpBinding** | |
| - `.ctor()` | |
| - `.ctor(BasicHttpSecurityMode)` | |
| - `CreateBindingElements()` | |
| * **BasicHttpsBinding** | |
| - `.ctor()` | |
| - `.ctor(BasicHttpsSecurityMode)` | |
| - `CreateBindingElements()` | |
| * **ChannelFactory** | |
| - `.ctor(Binding, EndpointAddress)` | |
| - `.ctor(ServiceEndpoint)` | |
| - `.ctor(String)` | |
| - `.ctor(String, EndpointAddress)` | |
| - `ApplyConfiguration(String)` | |
| - `CreateDescription()` | |
| - `InitializeEndpoint(Binding, EndpointAddress)` | |
| - `InitializeEndpoint(ServiceEndpoint)` | |
| - `InitializeEndpoint(String, EndpointAddress)` | |
| * **ChannelTerminatedException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **ClientBase** | |
| - `.ctor()` | |
| - `.ctor(String)` | |
| - `.ctor(String, EndpointAddress)` | |
| - `.ctor(String, String)` | |
| * **ClientBase+ChannelBase** | |
| - `EndInvoke(String, Object[], IAsyncResult)` | |
| * **ClientCredentialsSecurityTokenManager** | |
| - `CreateSecurityTokenAuthenticator(SecurityTokenRequirement, SecurityTokenResolver)` | |
| - `CreateSecurityTokenProvider(SecurityTokenRequirement)` | |
| - `CreateSecurityTokenSerializer(SecurityTokenVersion)` | |
| * **CommunicationException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **CommunicationObjectAbortedException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **CommunicationObjectFaultedException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **DuplexChannelFactory** | |
| - `.ctor(InstanceContext, Binding, EndpointAddress)` | |
| - `.ctor(InstanceContext, Binding, String)` | |
| - `.ctor(InstanceContext, String)` | |
| - `.ctor(InstanceContext, String, EndpointAddress)` | |
| * **DuplexClientBase** | |
| - `.ctor(InstanceContext)` | |
| - `.ctor(InstanceContext, String)` | |
| - `.ctor(InstanceContext, String, EndpointAddress)` | |
| - `.ctor(InstanceContext, String, String)` | |
| * **EndpointAddress** | |
| - `ApplyTo(Message)` | |
| * **EndpointIdentity** | |
| - `Equals(Object)` | |
| - `GetHashCode()` | |
| * **EndpointNotFoundException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **FaultException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **InvalidMessageContractException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **MessageHeaderException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **MessageSecurityOverTcp** | |
| - `get_ClientCredentialType()` | |
| - `set_ClientCredentialType(MessageCredentialType)` | |
| * **NetHttpBinding** | |
| - `CreateBindingElements()` | |
| * **NetHttpsBinding** | |
| - `.ctor()` | |
| - `.ctor(BasicHttpsSecurityMode)` | |
| - `CreateBindingElements()` | |
| * **NetTcpBinding** | |
| - `.ctor(String)` | |
| - `CreateBindingElements()` | |
| * **ProtocolException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **QuotaExceededException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **ServerTooBusyException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **ServiceActivationException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| ### System.ServiceModel.Channels | |
| * **AddressHeader** | |
| - `Equals(Object)` | |
| - `GetHashCode()` | |
| * **MessageHeaders** | |
| - `set_To(Uri)` | |
| * **SecurityBindingElement** | |
| - `CreateSecureConversationBindingElement(SecurityBindingElement)` | |
| * **TransportSecurityBindingElement** | |
| - `GetProperty<T>(BindingContext)` | |
| * **WebSocketTransportSettings** | |
| - `get_DisablePayloadMasking()` | |
| - `set_DisablePayloadMasking(Boolean)` | |
| ### System.ServiceModel.Security | |
| * **MessageSecurityException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **SecurityAccessDeniedException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **SecurityNegotiationException** | |
| - `.ctor(SerializationInfo, StreamingContext)` | |
| * **X509ServiceCertificateAuthentication** | |
| - `set_CertificateValidationMode(X509CertificateValidationMode)` |
Member
There was a problem hiding this comment.
Do we know what caused them to show up here in the first place?
adamsitnik
reviewed
Jul 15, 2020
Comment on lines
+121
to
+122
| - `EnterDebugMode()` | ||
| - `LeaveDebugMode()` |
Member
There was a problem hiding this comment.
these two are nops and to be consistent with other nops, we should remove them from the list
context: https://github.com/dotnet/designs/pull/138/files#r454448405
Suggested change
| - `EnterDebugMode()` | |
| - `LeaveDebugMode()` |
adamsitnik
reviewed
Jul 15, 2020
| ### System.IO.Pipes | ||
|
|
||
| * **NamedPipeClientStream** | ||
| - `Connect(Int32)` |
Member
There was a problem hiding this comment.
I can't see a code path where Connect(Int32) throws on Unix.
Suggested change
| - `Connect(Int32)` |
adamsitnik
reviewed
Jul 15, 2020
Comment on lines
+160
to
+161
| * **NamedPipeServerStream** | ||
| - `WaitForConnection()` |
Member
There was a problem hiding this comment.
it's supported on Unix: https://github.com/dotnet/runtime/blob/08643df14054d1273002254c909fa099649ebfcf/src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs#L54-L66
Suggested change
| * **NamedPipeServerStream** | |
| - `WaitForConnection()` |
adamsitnik
reviewed
Jul 15, 2020
Comment on lines
+209
to
+210
| * **Socket** | ||
| - `SetIPProtectionLevel(IPProtectionLevel)` |
Member
There was a problem hiding this comment.
Suggested change
| * **Socket** | |
| - `SetIPProtectionLevel(IPProtectionLevel)` | |
| * **Socket** | |
| - `.ctor(SocketInformation)` | |
| - `SetIPProtectionLevel(IPProtectionLevel)` |
adamsitnik
reviewed
Jul 15, 2020
|
|
||
| * **DriveInfo** | ||
| - `set_VolumeLabel(String)` | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| ### System.IO.FileSystem | |
| * **File** | |
| - `Decrypt(string)` | |
| - `Encrypt(string)` |
Member
|
FWIW I've done some simple manual search of keyword "PlatformNotSupportedException" in My PR is ready dotnet/runtime#39265 |
Contributor
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.