Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add document describing known issues in Ecma-335#5435

Merged
nguerrera merged 2 commits into
dotnet:masterfrom
nguerrera:spec-issues
Jan 15, 2016
Merged

Add document describing known issues in Ecma-335#5435
nguerrera merged 2 commits into
dotnet:masterfrom
nguerrera:spec-issues

Conversation

@nguerrera

Copy link
Copy Markdown
Contributor

@nguerrera

Copy link
Copy Markdown
Contributor Author

Also tagging @davkean and @CarolEidt

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a document where we could share issues more broadly - i.e. beyond those encountered in this context. Perhaps it belongs in the documentation directory of the coreclr repo (and yes, I realize that I'm probably the one that should create that ...)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd distinguish between ECMA-335 spec issues and implementation issues. Implementation issues in CLR should certainly be tracked by a document in coreclr repo. Since the goal of System.Reflection.Metadata package is provide public API for reading and writing ECMA-335 compliant files I think this repo is the right place for the spec errata.

Of course, we should push these changes into the ECMA-335 spec itself and once that's done we can delete this file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, I just wanted to save my notes. I'm not even sure what we should consider a spec bug and what we should consider implementation issues yet. I'd love to continue the conversation about the next steps towards where these notes should live, how they should be split, and the path towards amending the spec where appropriate, etc,, but I'd rather not block this PR on it.

@tmat

tmat commented Jan 15, 2016

Copy link
Copy Markdown
Member

👍

1 similar comment
@davkean

davkean commented Jan 15, 2016

Copy link
Copy Markdown
Member

👍

@tmat

tmat commented Jan 15, 2016

Copy link
Copy Markdown
Member

@migueldeicaza @jbevain Nick wrote up issues we have recently found in ECMA-335 spec. So far these are signature encoding issues. We will be adding other issues here, as well as proposals for spec corrections. We'd like to hear your feedback. Specifically, how Mono.Cecil and Mono runtime handle these corner cases currently and how do you feel about the proposed changes (once we include them in the document).

@tmat

tmat commented Jan 15, 2016

Copy link
Copy Markdown
Member

//cc @vargaz

@nguerrera

Copy link
Copy Markdown
Contributor Author

Added related issue links. Merging without waiting for tests since this is just a new .md file.

nguerrera added a commit that referenced this pull request Jan 15, 2016
Add document describing known issues in Ecma-335
@nguerrera nguerrera merged commit 3ac53f5 into dotnet:master Jan 15, 2016
@nguerrera nguerrera deleted the spec-issues branch January 15, 2016 18:49
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Add document describing known issues in Ecma-335

Commit migrated from dotnet/corefx@3ac53f5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants