This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Pass CancellationToken to DbDataReader#38331
Merged
Merged
Conversation
Contributor
Author
|
Yes, I can add some tests but it may take a while for me to setup the environment. I just edited it through github 😄 |
Contributor
Author
|
@stephentoub added tests |
Member
|
cc: @roji |
Member
|
Indeed, thanks for catching this... Will do an extra pass to make sure this isn't a problem elsewhere. Will also add cancellation tests for all other async APIs. |
Member
Member
|
Note #38453 which generalizes cancellation token tests to the entire async API surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like this was missed in #36123