This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add async methods in System.Data.Common, implement IAsyncDisposable#37877
Merged
Conversation
ajcvickers
reviewed
May 22, 2019
ajcvickers
approved these changes
May 22, 2019
ajcvickers
left a comment
There was a problem hiding this comment.
Looks good to me. @divega to double check the API surface.
stephentoub
reviewed
May 23, 2019
stephentoub
reviewed
May 23, 2019
stephentoub
reviewed
May 23, 2019
stephentoub
reviewed
May 23, 2019
stephentoub
reviewed
May 23, 2019
stephentoub
approved these changes
May 23, 2019
Member
Author
|
ping @divega for an extra set of eyes |
bgrainger
approved these changes
May 24, 2019
divega
approved these changes
May 30, 2019
divega
left a comment
There was a problem hiding this comment.
From what I can recall, when we did #36123 we learned that we don’t need to do the dance with partials and *.netcoreapp.cs files in product code, I think because we are no longer building the package that targets other TFMs from the source in master.
If this is true, my preference would be to consolidate the code files.
Other than that, everything looks good to me.
c481050 to
6259b22
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35012