This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add support for UTF8 Feature Extension#30917
Merged
Merged
Conversation
added 5 commits
June 19, 2018 13:51
…eature-extension
…eature-extension
udlingal
reviewed
Jul 9, 2018
| _defaultEncoding = System.Text.Encoding.GetEncoding(_defaultCodePage); | ||
| _defaultEncoding = Encoding.UTF8; | ||
| _defaultCollation = env.newCollation; | ||
| _defaultLCID = env.newCollation.LCID; |
Member
added 2 commits
July 11, 2018 16:41
Author
|
@dotnet-bot Test Windows x64 Debug Build |
saurabh500
reviewed
Jul 12, 2018
| _defaultCodePage = newCodePage; | ||
| _defaultEncoding = System.Text.Encoding.GetEncoding(_defaultCodePage); | ||
| _defaultEncoding = Encoding.UTF8; | ||
| _defaultCollation = env.newCollation; |
Contributor
There was a problem hiding this comment.
_defaultCollation = env.newCollation
This is set in both if and else. Can we move it out to before if and else.
Author
There was a problem hiding this comment.
Moved it out before if and else as requested.
saurabh500
approved these changes
Jul 12, 2018
udlingal
approved these changes
Jul 13, 2018
Author
|
@dotnet-bot Test Windows x64 Debug Build |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…extension Add support for UTF8 Feature Extension Commit migrated from dotnet/corefx@06b5dab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
UTF-8 Feature Extensionthat will be introduced in newer versions of SQL Server.