This repository was archived by the owner on Jan 23, 2023. It is now read-only.
ARM/Linux: Fix Exception Handler PAL Test Fail#5360
Merged
Conversation
The return address should be kept intact, not recovered just yet. It is going to be recovered by libgcc's rescore_core_regs much later, few instructions before heading back to "catch". Fixes #5358
Member
Awesome progress! |
Member
|
LGTM. Thanks! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The return address should be kept intact, not recovered just yet. It is going to be recovered by libgcc's rescore_core_regs much later, few instructions before heading back to "catch". Fixes dotnet/coreclr#5358 Commit migrated from dotnet/coreclr@594b424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return address should be kept intact, not recovered
just yet. It is going to be recovered by libgcc's
rescore_core_regs much later, few instructions before
heading back to "catch".
Fixes #5358
This fixes stack misalignment during exception handling as well.
With this, we see ALL the ARM/Linux PAL tests pass.