Moved allocator and GCStatistics into their own files.#403
Conversation
In gcpriv.h, there were 11 defines for dprintf that were commented out and clearly not in use.
GC Statistics module has been moved to its own file.
allocator (the class) now resides in gcallocator.h & gcallocator.cpp #includes were added to GCStatistics and allocator Copyright notice was copy pasted.
|
Hi @ala53, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
On the CLA, is there a way not to give my home address (I'd just prefer not to give out my personal information)? For now, I just wrote "Prefer not to disclose." |
|
@ala53, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Forgot to include gcallocator.h
Added the header to implementation includes. Moved alloc_list (class) to gcallocator.h
Moved #includes from .cpp to .h because GC.cpp defines max generation, which is needed in the headers
|
AAAAAAAAAAAaaaaaaaaaaaaaaaAAAAAAAAAAAAAAaaaaaaaaaaaaAAAAaaaaaaaaaaaaaaAAAA!!!!!1!1!!!!!1!!! The |
|
cc @Maoni0 |
Seemed to have been missing...
Turns out that max_generation was a hidden, private (anonymous) enum in gc.h, causing a bunch of issues.
|
@ala53, thank you very much for your contribution. It looks like this change is limited to formatting/re-organization changes. Per our contribution guidelines, we aren't planning to take pure formatting changes (https://github.com/dotnet/coreclr/wiki/Contribution-guidelines#formatting-changes). In addition to merge issues on the internal mirror, this also opens us up to copy-and-paste issues/bugs, as you experienced with the #includes. If you would like to see gc.cpp re-organized, I would recommend opening an issue so that we can discuss how best to approach this. |
It's a small change (mostly for code clarity) but now the allocator and statistics classes are no longer part of the 36,210 line monster that is
gc.cpp- nowgc.cppis only 35,905 lines. Progress!