API review rename of InitialIndex and ScrollToIndexAsync - #67312
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Blazor Virtualize<TItem> public API to reflect the API review decision by renaming the initial scroll parameter and programmatic scrolling method, and then aligns tests and test assets with the new names.
Changes:
- Renamed
InitialIndex→InitialItemIndexonVirtualize<TItem>. - Renamed
ScrollToIndexAsync(...)→ScrollToItemAsync(...)onVirtualize<TItem>. - Updated unit tests, E2E tests, and BasicTestApp virtualization test pages to use the renamed API, and updated
PublicAPI.Unshipped.txtaccordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Components/Web/test/Virtualization/VirtualizeTest.cs | Updates unit tests to call ScrollToItemAsync and use InitialItemIndex assertions/bindings. |
| src/Components/Web/src/Virtualization/Virtualize.cs | Renames the public API surface and updates related comments/error messages/internal call sites. |
| src/Components/Web/src/PublicAPI.Unshipped.txt | Updates the unshipped API declarations to the renamed members. |
| src/Components/test/testassets/BasicTestApp/VirtualizationAnchorModeWindowScroll.razor | Updates test UI to call ScrollToItemAsync. |
| src/Components/test/testassets/BasicTestApp/VirtualizationAnchorMode.razor | Updates test UI to bind InitialItemIndex and call ScrollToItemAsync. |
| src/Components/test/E2ETest/Tests/VirtualizationTest.cs | Updates E2E test text and parameter usage to reference ScrollToItemAsync/InitialItemIndex. |
dariatiurina
approved these changes
Jun 19, 2026
Member
Author
|
/ba-g failures are not connected |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename following the decision in #67065 (comment).
Fixes #67065