Fix intermittent circular dependency build failure#65667
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a sentinel MSBuild property to the PublishToSharedLayoutRoot self-invocation to prevent MSBuild from treating nested builds as having identical global properties (avoiding an intermittent circular target dependency failure).
Changes:
- Updates the
PublishToSharedLayoutRoottarget’s MSBuild invocation to include a sentinel property (_PublishingToLayout=true).
….sfxproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
BrennanConroy
approved these changes
Mar 5, 2026
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
11 tasks
SamMonoRT
approved these changes
Mar 6, 2026
This was referenced May 19, 2026
wtgodbe
added a commit
to wtgodbe/dotnet
that referenced
this pull request
May 19, 2026
The _PublishingToLayout workaround (dotnet/aspnetcore#65667) is no longer needed now that sharedfx.targets adds differentiating properties to its self-referencing MSBuild calls directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We occasionally see failures like:
The root cause of this is that
PublishToSharedLayoutRootcalls MSBuild on its own process, which then callsGetFilesToPublish, which again MSbuild's itself, but removes the setting ofOutputPathfrom line 141. So the inner-inner build has the same global properties as the outer build, which MSBuild detects as a circular dependency. If we set an arbitrary sentinel property in the MSBuild invocation inPublishToSharedLayoutRoot, then the global properties will no longer match.https://github.com/dotnet/dotnet/blob/856f69955c79a685a753283ea03701c4d04264ba/src/arcade/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L578-L583