[release/6.0-rc1] [SPA] Ensure spawned NPM processes are terminated when the dotnet process is ungracefully terminated#35701
Merged
Pilchie merged 4 commits intorelease/6.0-rc1from Aug 25, 2021
Conversation
…en the host dotnet process is ungracefully terminated.
Member
|
This was approved by Tactics over email. |
Pilchie
approved these changes
Aug 25, 2021
Member
Pilchie
left a comment
There was a problem hiding this comment.
Approving based on review of main PR.
captainsafia
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Update dependencies from https://github.com/dotnet/efcore build 20210824.20 (#35675) [release/6.0-rc1] Update dependencies from dotnet/efcore * [release/6.0-rc1] Update dependencies from dotnet/efcore dotnet/runtime (#35677) [release/6.0-rc1] Update dependencies from dotnet/efcore dotnet/runtime * Update dependencies from https://github.com/dotnet/efcore build 20210824.28 (#35681) [release/6.0-rc1] Update dependencies from dotnet/efcore * [release/6.0-rc1] Don't cache CanReuse value (#35676) * Don't cache CanReuse value * Comment on when to use CanReuse Co-authored-by: Sebastien Ros <sebastienros@gmail.com> * Fix key comparison for more than 10 elements in AdaptiveCapacityDictionary (#35705) Co-authored-by: Brennan <brecon@microsoft.com> * [release/6.0-rc1] [SPA] Ensure spawned NPM processes are terminated when the dotnet process is ungracefully terminated (#35701) * Adds a script to terminate the spawned NPM processes automatically when the host dotnet process is ungracefully terminated. Co-authored-by: Javier Calvarro Nelson <jacalvar@microsoft.com> * Update dependencies from https://github.com/dotnet/runtime build 20210825.7 (#35726) [release/6.0-rc1] Update dependencies from dotnet/runtime * Move IResultsExtension to M.A.Http namespace (#35717) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sebastien Ros <sebastienros@gmail.com> Co-authored-by: Brennan <brecon@microsoft.com> Co-authored-by: Javier Calvarro Nelson <jacalvar@microsoft.com> Co-authored-by: Safia Abdalla <safia@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #35591 to release/6.0-rc1
/cc @javiercn
Customer Impact
node processes are left open after stopping the application in VS 4 Mac.
Testing
Manual
Risk
Low.
The fix just launches a shell script that watches for the main process and when it detects its gone, it tries to kill all the process spawned by the spa process. In the worst case scenario, the processes are left alive, which is the current status quo.
We do have similar code in windows to account for when VS or someone else kills the app ungracefully