Skip to content

Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200514.9#21861

Closed
dougbu wants to merge 1 commit into
masterfrom
dougbu/prod.subscriptions
Closed

Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200514.9#21861
dougbu wants to merge 1 commit into
masterfrom
dougbu/prod.subscriptions

Conversation

@dougbu

@dougbu dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor
  • Microsoft.AspNetCore.Mvc.Razor.Extensions, Microsoft.AspNetCore.Razor.Language, Microsoft.CodeAnalysis.Razor, Microsoft.NET.Sdk.Razor
    • '5.0.0-preview.6.20264.6' => '5.0.0-preview.6.20264.9'
  • Numerous dotnet/runtime packages: '5.0.0-preview.5.20260.5' => '5.0.0-preview.6.20263.7'

…build 20200514.9

- Microsoft.AspNetCore.Mvc.Razor.Extensions, Microsoft.AspNetCore.Razor.Language, Microsoft.CodeAnalysis.Razor, Microsoft.NET.Sdk.Razor
  - '5.0.0-preview.6.20264.6' => '5.0.0-preview.6.20264.9'
- Numerous dotnet/runtime packages: '5.0.0-preview.5.20260.5' => '5.0.0-preview.6.20263.7'
@dougbu
dougbu requested review from a team and jkotalik May 15, 2020 04:08
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 15, 2020
@dougbu

dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

/fyi Looks like my local dependency updates in #21630 left things incoherent enough that triggering our subscription from aspnetcore-tooling isn't working.

@mmitche I had to run darc twice to make things right:

darc update-dependencies --source-repo aspnetcore-tooling --channel '.NET 5 Dev'
darc update-dependencies --coherency-only

Why didn't the coherency check in the first command do anything?

@mmitche

mmitche commented May 15, 2020

Copy link
Copy Markdown
Member

/fyi Looks like my local dependency updates in #21630 left things incoherent enough that triggering our subscription from aspnetcore-tooling isn't working.

@mmitche I had to run darc twice to make things right:

darc update-dependencies --source-repo aspnetcore-tooling --channel '.NET 5 Dev'
darc update-dependencies --coherency-only

Why didn't the coherency check in the first command do anything?

That is very odd...it should absolutely have done so. Do you have the source sha that you were on that showed the issue? (you can probably get it from git reflog)

@dougbu

dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

I was at 035fb4e in aspnetcore. The original aspnetcore-tooling and runtime SHAs are visible in the diffs here.

@dougbu

dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

The current conflicting files are also weird: 4c53afe updated dependencies from dotnet/efcore. But, it applied "Dependency coherency updates" on everything from dotnet/runtime. We have no CoherentParentDependency attributes pointing at anything from dotnet/efcore.

@dougbu

dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

@mmitche any luck so far❔

At this point, either I redo this branch based on the latest 'master' (to clear the conflicts) or you should figure out why triggering the aspnetcore-tooling ➡️ aspnetcore / 'master' subscription doesn't do anything. Your preference❔

@mmitche

mmitche commented May 15, 2020

Copy link
Copy Markdown
Member

@dougbu It's becuase the subscription was disabled:

https://github.com/dotnet/aspnetcore-tooling (.NET 5 Dev) ==> 'https://github.com/dotnet/aspnetcore' ('master')
  - Id: b4589d4d-ab29-4a8a-d45b-08d76e1d3434
  - Update Frequency: EveryBuild
  - Enabled: False
  - Batchable: True
  - Merge Policies:
    Standard

@dougbu

dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

Shoot, I forgot I did that while working on #21630❕ My bad and thanks for noticing.

But, I submit that it would be "nice" (at least) for darc trigger-subscriptions to display a warning instead of acting like the subscription the user thinks they're triggering will do something.

@dougbu

dougbu commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

Closing in favour of #21903 My thanks to @mmitche for noticing I'd "temporarily" disabled the subscription and hadn't re-enabled it yet. He also did the re-enablement 😃

@dougbu dougbu closed this May 15, 2020
@dougbu
dougbu deleted the dougbu/prod.subscriptions branch May 15, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants