[release/3.1] Add .version file to shared framework zip#21548
Merged
Conversation
Member
Author
|
Once build finishes I need to fixup the |
wtgodbe
marked this pull request as ready for review
May 6, 2020 23:02
dougbu
approved these changes
May 7, 2020
mthalman
approved these changes
May 7, 2020
JunTaoLuo
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #21177 by including a
.versionfile in our shared framework zip, and aversions.txtfile in our shared framework .nupkg. This more closely mimics what happens inmicrosoft.netcore.appTesting confirms that the shared framework zips now contain
.versioninshared\Microsoft.AspNetCore.App\3.1.4, while the .nupkg still includes aversions.txtfile.