Fix VSTest on Windows without globally installed SDK#6182
Merged
Conversation
Workaround until tracking issue dotnet/sdk#13611 is fixed. Unblocks dotnet/linker#1471
vitek-karas
approved these changes
Sep 16, 2020
vitek-karas
left a comment
Member
There was a problem hiding this comment.
I think it looks good (not much experience in this area though)
nohwnd
approved these changes
Sep 16, 2020
marek-safar
approved these changes
Sep 16, 2020
ViktorHofer
added a commit
that referenced
this pull request
Oct 9, 2020
This reverts commit 947ad5a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround until tracking issue dotnet/sdk#13611 is fixed. Unblocks dotnet/linker#1471. Not adding support for x86 intentionally as this is just a workaround.
cc @alexperovich @nohwnd