Remove PublishWindowsPdb & ConvertPortablePdbsToWindowsPdbs switches#15736
Open
ViktorHofer wants to merge 3 commits intomainfrom
Open
Remove PublishWindowsPdb & ConvertPortablePdbsToWindowsPdbs switches#15736ViktorHofer wants to merge 3 commits intomainfrom
ViktorHofer wants to merge 3 commits intomainfrom
Conversation
akoeplinger
previously approved these changes
Apr 14, 2025
Member
Author
|
@hoyosjs should the parts of https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Internal.SymbolHelper that deal with pdb conversion be removed as well? |
Member
|
I pushed that removal, let us know if it's still needed |
Member
|
Last I checked, the gate still required it |
Member
Author
|
the gate? You mean the stargate? 😌 |
Member
|
Insertion gates. Just a few months ago insertions would fail without conversion. |
Member
Author
|
VS shouldn't require Windows PDBs anymore. Roslyn doesn't produce them anymore (see the linked issue). Do you know to whom I can reach out to discuss this requirement? cc @marcpopMSFT |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15724
Fixes dotnet/dotnet#1017
To double check: