Locate VS 2017 installation of Android NDK#2
Merged
dellis1972 merged 1 commit intodotnet:masterfrom Jun 19, 2017
Merged
Conversation
The VS 2017 installer put my NDK in `C:\ProgramData\Microsoft\AndroidNDK64\android-ndk-r13b`
dellis1972
approved these changes
Jun 19, 2017
rmarinho
added a commit
that referenced
this pull request
Mar 13, 2026
Fix #1: Validate avdName in LaunchAvd (ArgumentException on null/empty) Fix #2: RunShellCommandAsync now returns full trimmed stdout (not just first line) Fix #3: Add 9 FirstNonEmptyLine parsing tests + 3 LaunchAvd validation tests Fix #5: Log stderr via logger on shell command failures (AdbRunner gets logger param) Fix #6: Remove TOCTOU HasExited check in TryKillProcess (rely on catch block) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rmarinho
added a commit
that referenced
this pull request
Mar 13, 2026
Fix #1: Validate avdName in LaunchAvd (ArgumentException on null/empty) Fix #2: RunShellCommandAsync now returns full trimmed stdout (not just first line) Fix #3: Add 9 FirstNonEmptyLine parsing tests + 3 LaunchAvd validation tests Fix #5: Log stderr via logger on shell command failures (AdbRunner gets logger param) Fix #6: Remove TOCTOU HasExited check in TryKillProcess (rely on catch block) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VS 2017 installer put my NDK in
C:\ProgramData\Microsoft\AndroidNDK64\android-ndk-r13bI think it should check for its location right before checking
C:\