Closed
Conversation
C++ standard library on macOS is too out of date to support `constexpr` `std::string`, don't use that then. Windows build required some minute changes to fix type cast issues and add missing include files.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrappers are needed to appease API Scan which doesn't find PDB files of renamed
binaries, such as
llvm-strip.exe(which is renamedllvm-objcopy.exe) andld.exe(which is renamedlld.exe). Both utilities look at theirargv[0]to determine the "mode" in which they should work.
llvm-objcopy.exerenamed tollvm-strip.execauses API Scan to not find the requiredPDB file (which we also rename, but whose original name is recorded in .exe).
lld.exeis a special case, because, unlikellvm-objcopy, it cannot be invokedunder this name. The utility will complain about
lldbeing a generic driver nameand that a specific one (such as
ld) must be used instead - i.e.,argv[0]mustbe that specific name.
In both cases adding a wrapper with the "target" name appeases API Scan and makes
the utilities work as we need them to.
This PR implements both wrappers and reorganizes the native code a bit so that portions
of it can be shared between the 3 wrappers that we now have (
asis another one). Tostay consistent, the wrappers are also used on Unix OS-es, even though they aren't necessary
there.