Skip to content

Tests | Fix random test failures#931

Merged
cheenamalhotra merged 9 commits into
dotnet:masterfrom
cheenamalhotra:fixTests
Feb 26, 2021
Merged

Tests | Fix random test failures#931
cheenamalhotra merged 9 commits into
dotnet:masterfrom
cheenamalhotra:fixTests

Conversation

@cheenamalhotra

@cheenamalhotra cheenamalhotra commented Feb 25, 2021

Copy link
Copy Markdown
Member

NotADatabase exception mismatch errors:

  • Compare error contents not object references

Transaction Deadlocked errors:

  • Rerun transaction as per recommended action.

KeyStoreProvider error mismatch:

  • Cleanup registered providers and run test cleanly.
  • Check for Contains instead of Equals for error messages.

Host name not found in "CreateCertificate()"

  • Reduced calls to CreateCertificate in same test class by making certificate static as it's not expected to change.

ConnectionSpeed Test improvements

  • Compare divided value as double
  • Disabled temporarily as it fails more often and not reproducible locally.

Compare error contents not object references
@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Feb 25, 2021
@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview1 milestone Feb 25, 2021
@cheenamalhotra cheenamalhotra changed the title Tests | Fix NotADatabase test random failures Tests | Fix random test failures Feb 25, 2021
@cheenamalhotra cheenamalhotra merged commit 565f131 into dotnet:master Feb 26, 2021
cheenamalhotra added a commit to cheenamalhotra/SqlClient that referenced this pull request Mar 3, 2021
@cheenamalhotra cheenamalhotra deleted the fixTests branch April 1, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants