Fix SupportsIntegratedSecurity Test Configuration

[paulmedynski]

Description

We have been skipping any tests that require Integrated Security. Our PR/CI pipelines appear to intend to use an Azure DevOps Library variable $(SupportsIntegratedSecurity), which is always true, but the tests still aren't running. This is because we use template expressions to convert the string library value to a YAML boolean parameter. But this doesn't work because the library variable $(SupportsIntegratedSecurity) isn't expanded at template expression evaluation time - it literally remains the string "$(SupportsIntegratedSecurity)".

I found all of the config properties that we're using as template expansion boolean values, and this was the only one using a runtime variable, so I just hardcoded them to true/false appropriately. I left a note in the YAML to help avoid this blunder in the future.

Testing

Normal PR and CI runs will show that the associated tests are no longer being skipped. One example is ADIntegratedUsingSSPI in the Manual Tests suite.

[Copilot]

Pull request overview

This draft PR investigates why Integrated Security tests are being skipped in the CI/CD pipeline. The author suspects that the Azure DevOps Library variable $(SupportsIntegratedSecurity) isn't being properly resolved, even though it should always be true. The PR hardcodes this value to true in the pipeline configuration to test whether this resolves the issue.

Changes:

• Hardcoded SupportsIntegratedSecurity: true in 6 test configurations that use local SQL Server instances (SQL 2019 x64, SQL 2019 x86, SQL 2022 x64, SQL 2022 x86, SQL 2022 named instance, and Always Encrypted tests)

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[paulmedynski]

Details of the failing tests:

• Failed Microsoft.Data.SqlClient.ManualTesting.Tests.LocalDBTest.LocalDbNamedPipeEncryptionNotSupportedTest [1 s]
• Failed Microsoft.Data.SqlClient.ManualTesting.Tests.LocalDBTest.SqlLocalDbNamedPipeConnectionTest [1 s]
• Failed Microsoft.Data.SqlClient.ManualTesting.Tests.LocalDBTest.LocalDbNamedPipeMarsTest [1 s]

All failures are the same:

Microsoft.Data.SqlClient.SqlException : A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: SQL Network Interfaces, error: 50 - Local Database Runtime error occurred. )

Conditions:

• Test Set 3
• .NET 8 and 9
• Windows
• Managed SNI
• Local SQL Server instance

Converting this back to a draft while I figure this out.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.96%. Comparing base (3ffbba7) to head (c03a44e).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3ffbba7) and HEAD (c03a44e). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (3ffbba7)	HEAD (c03a44e)
addons	1	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3887      +/-   ##
==========================================
- Coverage   74.53%   67.96%   -6.57%     
==========================================
  Files         266      260       -6     
  Lines       42915    65704   +22789     
==========================================
+ Hits        31987    44659   +12672     
- Misses      10928    21045   +10117     

Flag	Coverage Δ
addons	?
netcore	68.14% <ø> (-6.64%)	⬇️
netfx	66.66% <ø> (-7.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.