Skip to content

Complete port of PR 521 to netfx #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheenamalhotra merged 1 commit into from
Nov 7, 2024
Merged

Complete port of PR 521 to netfx #2964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3054,7 +3054,7 @@ virtual public int GetSqlValues(object[] values)

for (int i = 0; i < copyLen; i++)
{
values[_metaData.GetVisibleColumnIndex(i)] = GetSqlValueInternal(i);
values[i] = GetSqlValueInternal(_metaData.GetVisibleColumnIndex(i));
}
return copyLen;
}
Expand Down Expand Up @@ -3500,7 +3500,7 @@ override public int GetValues(object[] values)
// If this is sequential access, then we need to wipe the internal buffer
if ((sequentialAccess) && (i < maximumColumn))
{
_data[i].Clear();
_data[fieldIndex].Clear();
if (fieldIndex > i && fieldIndex > 0)
{
// if we jumped an index forward because of a hidden column see if the buffer before the
Expand Down