Skip to content

use System.Configuration.ConfigurationManager 8.0,#2284

Closed
ErikEJ wants to merge 1 commit into
dotnet:mainfrom
ErikEJ:issue-2232
Closed

use System.Configuration.ConfigurationManager 8.0,#2284
ErikEJ wants to merge 1 commit into
dotnet:mainfrom
ErikEJ:issue-2232

Conversation

@ErikEJ

@ErikEJ ErikEJ commented Dec 30, 2023

Copy link
Copy Markdown
Contributor

as it has less dependencies than previous versions

fixes #2232

as it has less dependencies than previous versions

fixes dotnet#2232
@codecov

codecov Bot commented Dec 30, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5794ab3) 72.64% compared to head (8046078) 72.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
- Coverage   72.64%   72.47%   -0.17%     
==========================================
  Files         310      310              
  Lines       62045    62045              
==========================================
- Hits        45070    44965     -105     
- Misses      16975    17080     +105     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.57% <ø> (-0.30%) ⬇️
netfx 69.91% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@David-Engel

Copy link
Copy Markdown
Contributor

We are trying not to make major version dependency changes (including transitive) within non-major version bumps of MDS. So we'll merge this after the 5.2 GA. We'll bump to MDS 6.0 and include this change. It would be a nice refactor if we could have different dependency versions for the different target frameworks. I think that would allow us to make changes like this without breaking others. For example, adding future .NET 10 support with different dependency versions without a MDS major version bump and without breaking apps still targeting .NET 8.

@ErikEJ

ErikEJ commented Jan 18, 2024

Copy link
Copy Markdown
Contributor Author

@David-Engel Ah - so that is why the .NET 8 dependencies are staying at 6.x (for 5.2 at least)

I will see if I can find an approach to grouping the dependencies better - it already happens in the .nuspec file.

@ErikEJ

ErikEJ commented Jan 18, 2024

Copy link
Copy Markdown
Contributor Author

Superseeded by #2303

@ErikEJ ErikEJ closed this Jan 18, 2024
@ErikEJ
ErikEJ deleted the issue-2232 branch February 7, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Configuration.ConfigurationManager Version

2 participants