Update | Update SSL certificate error messages#2060
Merged
Conversation
JRahnama
requested review from
David-Engel,
DavoudEshtehari,
Kaur-Parminder and
arellegue
June 14, 2023 02:10
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
David-Engel
reviewed
Jun 23, 2023
David-Engel
left a comment
Contributor
There was a problem hiding this comment.
There is another ValidateSslServerCertificate function below the one being modified that needs similar changes to what you are making (the serverCertificate connection option validation).
David-Engel
reviewed
Jun 28, 2023
Kaur-Parminder
marked this pull request as draft
July 6, 2023 22:15
David-Engel
reviewed
Jul 7, 2023
David-Engel
approved these changes
Jul 14, 2023
David-Engel
reviewed
Aug 21, 2023
DavoudEshtehari
approved these changes
Sep 1, 2023
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.Net 7 and greater versions has a new API X509Certificate2.MatchesHostname which could be used to determine if a provided hostname exists in certificate SANs or Subject, unfortunately that is not available in lower versions.
This PR updates the .Net 7 and greater versions with the new API and tries to provide more specific error on lower versions.