Perf: Cache delegates for non query and xml reader calls#1194
Closed
Wraith2 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I'm closing this because there is a cleaner and lower impact way to do this once #1084 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
ExecuteNonQueryAsyncandExecuteXmlReaderAsyncbegin and end delegates are passed toTask<T>.Factory.FromApmand because these are instance methods they cannot be cached meaning we have two delegates allocated per call. ExecuteNonQueryAsync is a very commonly used method so even small improvements here can have a large impact overall.I followed the general pattern introduced and used in ExecuteReaderAsync. I created static versions of the begin and end functions needed for each of the FromApm calls and made sure that the instance was passed as a state variable, the static functions simply unpack the instance from state and call the correct method on the instance. The static delegates are then cached as static readonly and re-used every time a call is made.
Note that the netfx version of ExecuteReaderAsync has not been altered because it will be dealt with by #1084