Fix RequestBodyFilterAnnotation and MultipleFromForm for MinimalApi

[jgarciadelanoceda]

Fixes #2662. Very similar to #2962 PR. When the RequestBody had a SwaggerRequestBody attribute the attribute was not applying and it provoked an exception

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (9b7c0dd) to head (914dd19).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2963      +/-   ##
==========================================
+ Coverage   90.34%   90.38%   +0.04%     
==========================================
  Files          72       72              
  Lines        2839     2851      +12     
  Branches      446      448       +2     
==========================================
+ Hits         2565     2577      +12     
  Misses        274      274              

Flag	Coverage Δ
Linux	90.38% <100.00%> (+0.04%)	⬆️
Windows	90.38% <100.00%> (+0.04%)	⬆️
macOS	90.38% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martincostello]

Could you add a test that shows the description in the attribute is rendered in the generated document please?

The test change here only checks it doesn't cause generation to fail.

[jgarciadelanoceda]

It's tested in the test Apply_EnrichesRequestBodyMetadata_IfControllerParameterDecoratedWithSwaggerRequestBodyAttribute of the file AnnotationsRequestBodyFilterTests

[martincostello]

I feel we're still missing something in our coverage here, as if we were validating the generated content for a Minimal API using this we would have found this bug before now.

[jgarciadelanoceda]

Yeah.. I do agree, altough there is no test for any MinimalApi (Apart from the IntegrationTests). I do not know how to fit this missing tests in the library(You cannot do a MapGet if there is no app. I think that we must create an issue to test the different apis using MinimalApi

[martincostello]

A verification test from the websites should fit this sort of niche.

If we had some in this area already, your addition would have caused a test to fail as the description would have changed, even if the original bug wasn't there.

That suggests to me adding such a test would give us the coverage that the document is what we expect and draw attention to future changes to ensure they are intentional.

[jgarciadelanoceda]

Ok, I will add Verify test to the webSites and try to fit the current MinimalApi issues I found over Swashbuckle.

[jgarciadelanoceda]

This last commit also fixes #2912.
Added test for the diferent MinimalApi method documentation.

@martincostello, I think that docummenting with AllOf solves the problem of MinimalApi, the parameters are being mapped correctly and the doubt is if it's the most appropiate solution

[jgarciadelanoceda]

@martincostello I do not know how the release notes are going to be generated (For the version 6.7.0) but the description of [Fix RequestBodyFilterAnnotation for Minimal API) is missing the multiple FromForms part

[martincostello]

They're auto-generated by GitHub and then I'll manually edit anything missing/incorrect.