Skip to content

feat(search-plugin): add namespace option#706

Merged
QingWei-Li merged 2 commits intomasterfrom
fix/697
Dec 5, 2018
Merged

feat(search-plugin): add namespace option#706
QingWei-Li merged 2 commits intomasterfrom
fix/697

Conversation

@cheng-kang
Copy link
Copy Markdown
Contributor

Issue

Local storage stores data per domain. [1]

It's unique per protocol://host:port combination.

Take the example in #697:

They are under the same domain https://ramblerw.github.io. Thus, they share the same search index data.

This PR

Introduces a new option: namespace, to avoid local storage collision.

If namespace is set, search index data will be saved under a namespaced key, e.g. docsify.search.index/docsify-test-namespace.

Fixes #697


Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@QingWei-Li QingWei-Li merged commit 28beff8 into master Dec 5, 2018
@cheng-kang cheng-kang deleted the fix/697 branch December 5, 2018 19:08
@libotony
Copy link
Copy Markdown

I am having the same problem, when will this feature be released?

QingWei-Li pushed a commit that referenced this pull request Feb 19, 2019
* feat(search-plugin): add namespace option

* docs(search-plugin): update doc for option namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants