Skip to content

#679 Remove only first custom id for a heading instead of all of them. #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sylwekb wants to merge 1 commit into from
Closed

#679 Remove only first custom id for a heading instead of all of them. #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/render/compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function getAndRemoveConfig(str = '') {
str = str
.replace(/^'/, '')
.replace(/'$/, '')
.replace(/:([\w-]+)=?([\w-]+)?/g, (m, key, value) => {
.replace(/:([\w-]+)=?([\w-]+)?/, (m, key, value) => {
Copy link
Contributor

@cheng-kang cheng-kang Nov 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for extracting all possible configs. In the case of headings, we have only one at the moment.

I guess a better solution would be only match strings at the end. We may need to introduce a delimiter for determining where the starting point of configs is.

config[key] = (value && value.replace(/"/g, '')) || true
return ''
})
Expand Down