Dockerfile for cross compilation#219
Merged
thaJeztah merged 3 commits intodocker:masterfrom Aug 20, 2022
Merged
Conversation
thaJeztah
reviewed
Aug 20, 2022
Member
thaJeztah
left a comment
There was a problem hiding this comment.
overall looks good (thanks!) some questions
| @@ -0,0 +1,82 @@ | |||
| # syntax=docker/dockerfile:1 | |||
|
|
|||
| ARG GO_VERSION=1.16.7 | |||
Member
There was a problem hiding this comment.
(After this?) we should update to a current version of Go
Member
Author
There was a problem hiding this comment.
Yes just keeping minimal atm
| FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx | ||
|
|
||
| # osxcross contains the MacOSX cross toolchain for xx | ||
| FROM crazymax/osxcross:${OSXCROSS_VERSION} AS osxcross |
Member
There was a problem hiding this comment.
This is built from https://github.com/crazy-max/osxcross ? Or from the upstream one? (I see neither repo tags releases, so was wondering what version it was built from)
Member
Author
There was a problem hiding this comment.
This is built from https://github.com/crazy-max/osxcross ?
It's built from https://github.com/crazy-max/docker-osxcross
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #209 to split a bit what was done.
This one adds a Dockerfile to ease cross compilation and a simple GHA workflow that will just build the Dockerfile. Jenkinsfile has been removed as it's not used anymore. In another follow-up we can move the travis pipeline to GHA.
Build example: https://github.com/crazy-max/docker-credential-helpers/actions/runs/2288625907
cc @thaJeztah @ebriney